From 8a25f8a511e9b610800555e3ac307afdc34b2aed Mon Sep 17 00:00:00 2001 From: dags- Date: Sun, 14 Jun 2020 12:30:58 +0100 Subject: [PATCH] tweak wording --- src/main/java/com/terraforged/chunk/TerraContext.java | 4 ++-- src/main/java/com/terraforged/config/ConfigManager.java | 8 ++++---- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/main/java/com/terraforged/chunk/TerraContext.java b/src/main/java/com/terraforged/chunk/TerraContext.java index cf78013..0228940 100644 --- a/src/main/java/com/terraforged/chunk/TerraContext.java +++ b/src/main/java/com/terraforged/chunk/TerraContext.java @@ -78,12 +78,12 @@ public class TerraContext extends GeneratorContext { CommentedConfig config = PerfDefaults.getAndPrintPerfSettings(); boolean batching = config.getOrElse("batching",false); int tileSize = Math.min(PerfDefaults.MAX_TILE_SIZE, Math.max(2, config.getInt("tile_size"))); - int batchSize = Math.min(PerfDefaults.MAX_BATCH_SIZE, Math.max(1, config.getInt("batch_size"))); + int batchCount = Math.min(PerfDefaults.MAX_BATCH_SIZE, Math.max(1, config.getInt("batch_count"))); int threadCount = Math.min(PerfDefaults.MAX_THREAD_COUNT, Math.max(1, config.getInt("thread_count"))); return RegionGenerator.builder() .pool(ThreadPools.create(threadCount, batching)) .size(tileSize, 2) - .batch(batchSize) + .batch(batchCount) .factory(factory) .build().toCache(); } diff --git a/src/main/java/com/terraforged/config/ConfigManager.java b/src/main/java/com/terraforged/config/ConfigManager.java index feea59e..e4359e5 100644 --- a/src/main/java/com/terraforged/config/ConfigManager.java +++ b/src/main/java/com/terraforged/config/ConfigManager.java @@ -50,16 +50,16 @@ public class ConfigManager { "batching", true, "Batching breaks heightmap tiles up into smaller pieces that can be generated concurrently.", - "This can help improve generation speed by utilizing more CPU cores.", - "It is better suited to higher core-count machines (6+ cores)" + "This can help improve generation speed by utilizing more threads.", + "It is more effective when a higher thread count (+6) is available." ); set( cfg, - "batch_size", + "batch_count", PerfDefaults.BATCH_SIZE, "Controls the number of pieces a heightmap tile is divided up into.", - "Higher core count CPUs may benefit from higher batch sizes." + "Higher batch counts may be able to utilize more of the available threads, improving performance." ); }));